Does on have a short vowel sound?

No, "on" does not have a short vowel sound. It has a long vowel sound, similar to the "o" in "bone" or "tone".

The "o" in "on" is a diphthong, which is a combination of two vowel sounds. In this case, it's a combination of the "ah" sound and the "n" sound.